fix(github-issues): quote array params for zsh, correct stale MCP write claim - #2864
Open
m2moiz wants to merge 1 commit into
Open
fix(github-issues): quote array params for zsh, correct stale MCP write claim#2864m2moiz wants to merge 1 commit into
m2moiz wants to merge 1 commit into
Conversation
…te claim `-f labels[]="bug"` fails under zsh, the default shell on macOS, because `[]` is a glob pattern. The argument never reaches gh. Quote the whole `name[]=value` pair instead. The skill also states the MCP server cannot create, update, or comment on issues. github-mcp-server ships issue_write, add_issue_comment, and sub_issue_write. Documented them and reworded the CLI section; the gh api examples are unchanged.
Contributor
🔒 PR Risk Scan ResultsScanned 1 changed file(s).
✅ No matching risk patterns were detected in changed files.
|
Contributor
🔍 Vally Lint Results✅ All checks passed
Summary
Full linter output |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two things in
skills/github-issues/SKILL.mdare wrong. Both bit me while setting the skill up.1.
-f labels[]="bug"fails on macOS[]is a glob pattern in zsh, which is the default shell on macOS. The argument never reachesgh:Quoting the whole pair fixes it:
-f 'labels[]=question'. Same forassignees[]. Anyone following the skill verbatim on a Mac hits this on their first create call.2. The MCP server can write issues now
The skill says:
issue_write(create and update),add_issue_comment, andsub_issue_writeall ship in github-mcp-server. They are listed in the server README under the issues toolset.I left every
gh apiexample alone. They work, and the CLI is still the right answer when the server is not connected or you need a REST field the tools do not expose. This just stops the skill asserting the MCP server cannot do something it can.How I checked
Created and closed a real issue against a repo of my own:
gh api ... -X POSTfor the create,issue_writewithmethod: updatefor the close. Both worked. The zsh failure above is copy-pasted from that session.One thing I did not touch
type=is silently dropped on user-owned repos, because issue types are org-level. The create returns 201 with"type": nulland no warning, so it looks like it worked. The skill already notes types are org-level metadata, so I left it alone, but a sentence saying the parameter fails silently outside an org might save someone an hour.